[Bug 374771] Review Request: smstools - Tools for send and receive short messages through GSM modems or mobile phones

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smstools - Tools for send and receive short messages through GSM modems or mobile phones


https://bugzilla.redhat.com/show_bug.cgi?id=374771





------- Additional Comments From lkundrak at redhat.com  2007-11-12 11:28 EST -------
Sooo, Marek:

In my opinion you shouldn't change modes in threee different places; (ugly
chmods in %prep, install -m %install and %attr in %files).

And RPMlint:

smstools.i386: W: file-not-utf8
/usr/share/doc/smstools-3.0.6/manual/softwarecomp.html
...

Alreay discussed that, not a problem.

smstools.i386: W: file-not-utf8
/usr/share/doc/smstools-3.0.6/examples/send_sms_unicode.sms

UNICODE example, whouldn't make sense if was utf8

smstools.i386: E: non-standard-dir-perm /var/spool/sms/failed 0750
smstools.i386: E: non-standard-dir-perm /var/spool/sms/checked 0750
smstools.i386: E: non-standard-dir-perm /var/spool/sms/outgoing 0750
smstools.i386: E: non-readable /etc/smsd.conf 0600
smstools.i386: E: non-standard-dir-perm /var/spool/sms/sent 0750
smstools.i386: E: non-standard-dir-perm /var/spool/sms/incoming 0750
smstools.i386: E: non-standard-dir-perm /var/spool/sms 0750

I think this is all intended

smstools.i386: E: incoherent-subsys /etc/rc.d/init.d/smsd smstools
smstools.i386: E: incoherent-subsys /etc/rc.d/init.d/smsd smstools
smstools.i386: E: incoherent-subsys /etc/rc.d/init.d/smsd smstools

Using /var/lock/subsys/smsd for a subsys lock instead of
/var/lock/subsys/smstools would make more sense in my opinion.

smstools.i386: W: incoherent-init-script-name smsd

Perfectly ok

smstools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 66, tab: line 1)

Run expand on the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.