[Bug 382551] Review Request: ebview - EPWING CD-ROM dictionary viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ebview - EPWING CD-ROM dictionary viewer


https://bugzilla.redhat.com/show_bug.cgi?id=382551





------- Additional Comments From akahl at iconmobile.com  2007-11-15 06:28 EST -------
(In reply to comment #2)
> (In reply to comment #1) 
> > Only three questionable items:
> > - /usr/share/ebview/about.jp is not UTF-8 but ISO-8859 encoded, is this
> > necessary for the runtime?
>   - This is encoded with EUC-JP (, which is very common on Japanese
>     Unix system) and this file is actually needed.
OK

> > - ebview.spec:68: --with-eb-conf=%{_libdir}/eb.conf
>   %_libdir/eb.conf is included in eb-devel, not in this package.
I see, just checked eb-devel's spec file. I wonder how eb.conf could possibly
belong into %{_libdir}, but that issue is not part of this review.
 
> > - On startup, pango warns
> > (ebview:9142): Pango-WARNING **: couldn't load font "Sazanami Mincho 12",
> > falling back to "Sans 12", expect ugly output.
> > Since your scriptlet (re)defines the default font in src/preference.c to
> > Sazanami, you should add a Require for this font.
>   Sazanami is in default Japanese desktop environ (from comps.xml).
>   Anyway this package requires Japanese fonts (this package is for
>   Japanese people), and even if Sazanami is not installed, this
>   package should work is one Japanese font (in Fedora) is installed.
Could you please add
Requires: sazanami-fonts-mincho
anyway so even on non-Japanese installations all characters are displayed
properly? I don't have any Japanese font installed and many characters are
unavailable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.