[Bug 374611] Review Request: pam_mysql - PAM module for auth UNIX users using MySQL data base

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_mysql - PAM module for auth UNIX users using MySQL data base


https://bugzilla.redhat.com/show_bug.cgi?id=374611


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




------- Additional Comments From wolfy at nobugconsulting.ro  2007-11-15 10:35 EST -------
I am using this very version for quite some time, so I guess I could review it.


There are a few items which need fixing:
a) rpmlint complains about the source:
1) pam_mysql.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1)
this is cosmetic, obvious fix
2) pam_mysql.src: W: non-standard-group Base
I suggest System Environment/Base, just like pam
3) pam_mysql.src: W: invalid-license GPL
Should probably be replaced with GPLv2+

b) rpmlint also complains about the binary
file-not-utf8 /usr/share/doc/pam_mysql-0.7/CREDITS
I guess iconv would fix this

c) the .so is installed in /lib[64]/security/, therefore you should Require pam

d) a minor issue is that there are some uplicate BuildRequires: openssl-devel
(by mysql-devel), zlib-devel (by openssl-devel)

a2, a3 and c are MUSTFIXES. Please have at least those ones fixed and afterwards
I'll do the full review.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.