[Bug 307901] Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information.


https://bugzilla.redhat.com/show_bug.cgi?id=307901





------- Additional Comments From wolfy at nobugconsulting.ro  2007-11-15 16:44 EST -------
I am not a sponsor, so I cannot do an official review.
However, I will try to push this a bit.
Comments about your spec:
- rpm is not meant to be used as a shell, therefore the first line of the spec
(#! /usr/bin/rpm) should not be there
- the preferred way to reference files hosted at sourceforge is described at
http://fedoraproject.org/wiki/Packaging/SourceURL?highlight=%20downloads.sourceforge%20#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2
(For packages hosted on sourceforge, use Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz)
In your case, the source is called %{name}-%{version}.src.tar.gz so adapt as needed.

rpmlint has several complains:
lsvpd.src: W: mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 5)
-> easy one, cosmetic fix
lsvpd.src: W: non-standard-group System Environment
-> try to pick a better group description
lsvpd.src: E: no-changelogname-tag
-> add ad least one proper entry to %changelog
lsvpd.src: W: invalid-license GPL
-> license should probably be GPLv2 or even GPLv2+


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.