[Bug 384191] Review Request: libdiscid - A library for creating MusicBrainz DiscIDs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libdiscid - A library for creating MusicBrainz DiscIDs
Alias: libdiscid

https://bugzilla.redhat.com/show_bug.cgi?id=384191





------- Additional Comments From kwizart at gmail.com  2007-11-16 07:02 EST -------
* Archive file has a better timestamp now - OK

* In Description %{name} is used.. As description need to be a full phrase, we
"usually" begin phrase with a cap...(ie Libdiscid or use This C Library is
for...) - NEED_WORK

* Requires:  pkgconfig is missing in -devel - NEED_WORK

* -devel provide a header into it owns directory, but libdiscid.pc do not
mention this directory...  - SHOULD
This wouldn't cost to have .pc.in patched so it can point to this directory...
Packages that will be built upon this one may fails if they only has #include
<discid.h> - 
What i understand for now is that none app currently directly links to it...:
"this is not a direct wrapper, but contains functions to access libdiscid using
it's own API" - But it would be fine to have it point the right
_includedir/discid if any want to acces it directly later... (I leave this point
up to you..)

* Please save header timestramp to change having : - NEED_WORK
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 
This will prevents multilibs systems to consider the file different has
timestamp will be changed at build time...

* As a COPYING file is present you must include it...  - NEED_WORK


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.