[Bug 381051] Review Request: R-abind - Combine multi-dimensional arrays

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-abind - Combine multi-dimensional arrays


https://bugzilla.redhat.com/show_bug.cgi?id=381051


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-17 21:00 EST -------
I note that while installing dependencies for this program I got this:

*** Cannot find any Java interpreter
*** Please make sure 'java' is on you PATH or set JAVA_HOME correspondingly

I guess the call to R CMD javareconf in the R %post scriptlet causes this.

This package builds fine with the usual rpmlint complaints:
  R-abind.noarch: W: one-line-command-in-%post 
   /usr/lib/rpm/R-make-search-index.sh
  R-abind.noarch: W: one-line-command-in-%postun 
   /usr/lib/rpm/R-make-search-index.sh
We should probably pester scop to work around this.

Do you know how to read R test suite output?  I still don't, so I can't tell if
the diffs shown in the output are cause for concern or not.  The tests all end
with OK, which I'm taking to mean "test passed".

* source files match upstream:
   f7c0ff0db4719edbb330ec183b1b10478af96345078cf40150efef895154a082  
   abind_1.1-0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint has only the expected complaints
* final provides and requires are sane:
   R-abind = 1.1-1.fc9
  =
   /bin/sh
   R
* %check is present and all tests pass, as far as I can tell.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R index generation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.