[Bug 381061] Review Request: R-acepack - ACE and AVAS methods for choosing regression transformations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-acepack - ACE and AVAS methods for choosing regression transformations


https://bugzilla.redhat.com/show_bug.cgi?id=381061


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-17 21:16 EST -------
Fails to build for me; adding BR: gcc-gfortran gets it going.

Interesting bit with ace-copyright.txt.  It seems that too few academics pay any
attention to licensing.

* source files match upstream:
   19b4d2b782c7ee13c9b8805c477d1bfd443556402898aff22b791ab64494f437  
   acepack_1.3-2.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires missing gcc-gfortran.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64) (after fixing BRs)
* package installs properly
* debuginfo package looks complete.
* rpmlint has only the expected complaints.
* final provides and requires are sane:
   acepack.so()(64bit)
   R-acepack = 1.3-1.fc9
  =
   /bin/sh
   R
   libR.so()(64bit)
   libgcc_s.so.1()(64bit)
   libgfortran.so.1()(64bit)
* %check is present and all tests pass.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R index generation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED, though obviously you'll need to fix the gfortran thing before you can
build.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.