[Bug 376531] perl-Dir-Which - Search for directory entries in a list of directories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: perl-Dir-Which - Search for directory entries in a list of directories


https://bugzilla.redhat.com/show_bug.cgi?id=376531





------- Additional Comments From tibbs at math.uh.edu  2007-11-17 23:50 EST -------
Hmm, cpanspec sure seems to generate prettier Perl module specfiles than
cpan2rpm.  Honestly it would be much simpler if you installed cpanspec, ran
"cpanspec Dir::Which", change License: as appropriate and add
  BuildRequires: perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage)
to get a perfectly acceptable package.

I'll go ahead and review the current package, but there are very many negative
comments.  To find more information about many of these, you can consult the
packaging guidelines at http://fedoraproject.org/wiki/Packaging/Guidelines.

It's not usual Fedora style to have all of the specfile tags in lower case, but
it's OK.

Don't use Packager:.

You aren't using the %dist tag in your Release.  It's not mandatory, but for a
new packager it's recommended.  I'd ask that you demonstrate that you understand
how to manage a package across multiple releases without it.  See
http://fedoraproject.org/wiki/Packaging/DistTag for more information.

Don't use Vendor:.

The License: tag isn't proper; see http://fedoraproject.org/Licensing for proper
license tags.  Also note that the CPAN page lists a completely different license.

The URL: should point to something relevant to the package, not just to the CPAN
main page.  Probably http://search.cpan.org/dist/Dir-Which/.

BuildRoot: is not proper; please use one of the approved BuildRoots: or at least
include %{release}.

Don't use Prefix:

You are missing the proper dependency on perl(:MODULE_COMPAT_...).

I am not sure why the complicated %build section is needed.  Why all of the grep
and xargs stuff?  Does it not suffice to do the usual
  %{__perl} Build.PL installdirs=vendor
  ./Build
?  And the "Build test" call goes in %check, not in %build.

%install should not ever call brp-compress.

The entire "SuSE Linux" stuff should all go; this is a Fedora package.

I don't even inderstand the block starting with "%{__perl} -MFile::Find -le '";
why is it needed?

%install and %clean don't need to check that the buildroot isn't "/"; you set it
to something other than "/" earlier in the spec.

I put the  cpanspec-generated spec at
http://www.math.uh.edu/~tibbs/perl-Dir-Which.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.