[Bug 225654] Merge Review: control-center

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: control-center


https://bugzilla.redhat.com/show_bug.cgi?id=225654


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora




------- Additional Comments From mclasen at redhat.com  2007-11-18 01:00 EST -------
I've just done some more patch cleanups.
Here is what rpmlint currently says:

[mclasen at localhost devel]$ rpmlint control-center-2.21.2-2.fc9.i386.rpm 
control-center.i386: W: devel-file-in-non-devel-package
/usr/share/pkgconfig/gnome-keybindings.pc

Could perhaps be moved to the -devel package, I guess

control-center.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_screensaver.schemas
control-center.i386: W: non-conffile-in-etc
/etc/gconf/schemas/desktop_gnome_font_rendering.schemas
control-center.i386: W: non-conffile-in-etc
/etc/gnome-vfs-2.0/modules/font-method.conf
control-center.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_keybindings.schemas
control-center.i386: W: non-conffile-in-etc
/etc/gconf/schemas/control-center.schemas
control-center.i386: W: non-conffile-in-etc /etc/gconf/schemas/themus.schemas
control-center.i386: W: non-conffile-in-etc /etc/xdg/menus/gnomecc.menu
control-center.i386: W: non-conffile-in-etc
/etc/gnome-vfs-2.0/modules/theme-method.conf
control-center.i386: W: non-conffile-in-etc
/etc/xdg/autostart/gnome-at-session.desktop
control-center.i386: W: non-conffile-in-etc /etc/gconf/schemas/fontilus.schemas
control-center.i386: W: file-not-utf8 /usr/share/doc/control-center-2.21.2/NEWS
control-center.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_default_editor.schemas

All of these follow established practise, I think

control-center.i386: E: explicit-lib-dependency libgail-gnome

This is rpmlint being too stupid. libgail-gnome doesn't actually
contain a library, but only a module.

control-center.i386: W: incoherent-version-in-changelog 2.21.2-2 1:2.21.2-2.fc9

Should probably be cleaned up


control-center.i386: W: obsolete-not-provided gnome
control-center.i386: W: obsolete-not-provided fontilus

Not a big deal, but I believe these obsoletes can be removed without harm.


control-center.i386: E: invalid-desktopfile
/usr/share/applications/gnome-themus-theme-applier.desktop
control-center.i386: E: invalid-desktopfile
/usr/share/applications/gnome-theme-installer.desktop

Not sure what to do about these. 
We need some way to totally hide these desktop files from the menus.


[mclasen at localhost devel]$ rpmlint control-center-devel-2.21.2-2.fc9.i386.rpm 
control-center-devel.i386: W: no-documentation

This is ignorable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.