[Bug 383501] Review Request: perl-Getopt-Euclid - Build command-line argument parser matching POD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Getopt-Euclid - Build command-line argument parser matching POD


https://bugzilla.redhat.com/show_bug.cgi?id=383501


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-18 02:01 EST -------
So, a clean package; I can find nothing to complain about.  Which is very rare
for a first package (even a Perl one).  Congratulations!

* source files match upstream:
   6444f685d24efd865583fc1973207cc9a303b8edb3f1fd52ab7efc86ec91540b  
   Getopt-Euclid-v0.1.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Getopt::Euclid)
   perl(Getopt::Euclid::HierDemo)
   perl-Getopt-Euclid = 0.1.0-1.fc9
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(File::Spec::Functions)
   perl(Getopt::Euclid)
   perl(List::Util)
   perl(re)
   perl(strict)
   perl(version)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=32, Tests=232,  2 wallclock secs ( 1.36 cusr +  0.49 csys =  1.85 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

I will sponsor you; go ahead and apply for cvsextras access and I'll click the
appropriate button when I see the request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.