[Bug 329291] Review Request: debootstrap - Bootstrap a basic Debian GNU/Linux system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: debootstrap - Bootstrap a basic Debian GNU/Linux system
Alias: debootstrap-review

https://bugzilla.redhat.com/show_bug.cgi?id=329291





------- Additional Comments From lkundrak at redhat.com  2007-11-18 05:05 EST -------
(In reply to comment #15)
> I attached a modified version of a patch to keep the timestamp
> of the installed scripts. This could be perfected by a
> 
> touch -r debootstrap $RPM_BUILD_ROOT%{_sbindir}/debootstrap

I don't see a good reason to keep the timestamps as this is a noarch package. I
would either keep all timestamps (adding that touch command) or not make any
effort to keep those. I choose the second option unless anyone convinces me.

> Currently the rpm macros are not used because /usr/share and 
> /usr/sbin are hardcoded in some places. You could overcome that by
> 
> - doing a sed s;/usr/share;%{_datadir}; on debootstrap
> - doing a sed s;/usr/sbin;%{_sbindir}; on the Makefile
> - passing DSDIR=$RPM_BUILD_ROOT%{_datadir}/debootstrap on the
>   make install line
> 
> I think it would be better, but I won't make that a blocker.
> May be done after importing.

I don't like the extra commands in the spec. There are no many packages that do
that and there's little chance that someone's %{_prefix} won't be /usr. I won't
mind it if you commit this to the package either :)

> APPROVED

Much thanks for the review!

> I am willing to maintain EL-4 and EL-5 branches, if you don't
> want to and accept me as a comaintainer for EPEL.

(In reply to comment #3)
> I'd be glad if you comaintained the package once it is approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.