[Bug 379751] Review Request: emacs-common-ess - Emacs Speaks Statistics add-on package for Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-common-ess -  Emacs Speaks Statistics add-on package for Emacs


https://bugzilla.redhat.com/show_bug.cgi?id=379751





------- Additional Comments From alexl at users.sourceforge.net  2007-11-18 06:15 EST -------
(In reply to comment #2)

> Seems to build OK for me, although I saw complaints about not being to find any
> version of R installed.  Will the built packages properly support R if it's not
> in the buildroot?

Builds OK in koji without R

http://koji.fedoraproject.org/koji/taskinfo?taskID=246902

I then also downloaded the builds and tested them locally and editing R worked
as did the interactive R mode.

> Not that it matters, but why not use %{pkgname} in the Summary, too?

Done.
 
> The install-info dependencies aren't quite right.  If you use something in
> %post, you need Requires(post). 
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets should have a template
> for installing texinfo files.

Fixed.

> rpmlint says:
> 
>   emacs-common-ess.noarch: W: file-not-utf8 
>    /usr/share/doc/emacs-common-ess-5.3.6/ChangeLog.lisp
>   emacs-common-ess.noarch: W: file-not-utf8 
>    /usr/share/doc/emacs-common-ess-5.3.6/doc/TODO
>   emacs-common-ess.noarch: W: file-not-utf8 
>    /usr/share/doc/emacs-common-ess-5.3.6/ChangeLog
> These should be passed through iconv.

Fixed

>   emacs-ess.noarch: W: no-documentation
>   emacs-ess-el.noarch: W: no-documentation
>   xemacs-ess.noarch: W: no-documentation
>   xemacs-ess-el.noarch: W: no-documentation
> I don't think these are problematic.
> 
>   emacs-ess.noarch: E: non-executable-script 
>    /usr/share/emacs/site-lisp/ess/etc/backbugs.sparc 0644
>   emacs-ess.noarch: E: non-executable-script 
>    /usr/share/emacs/site-lisp/ess/etc/ess-sas-sh-command 0644
>   emacs-ess.noarch: E: non-executable-script 
>    /usr/share/emacs/site-lisp/ess/etc/backbug5 0644
>   emacs-ess.noarch: E: non-executable-script 
>    /usr/share/emacs/site-lisp/ess/etc/backbug5.sparc 0644
>   emacs-ess.noarch: E: script-without-shebang 
>    /usr/share/emacs/site-lisp/ess/etc/BACKBUGS.BAT

These should be fixed now.

> I'm not really sure what the point of these files (and the rest of the ess/etc
> directory) is.  Certainly the BAT files have no real place on Linux.  Are any of
> them actually relevant?  What will call them?

Some of these files are needed at runtime (they are called out by the Lisp code)
such as backbugs.  I've removed all the unnecessary files such as the BAT files,
and others which shouldn't have been installed in the first place (now in %doc),
leaving just the files that the Lisp package appears to actually use.

So here are the updated files:

* Sun Nov 18 2007 <alexlan at fedoraproject.org> - 5.3.6-2
- Moved all non-code related files in etc/ to documentation directory
- Make sure all doc files are UTF-8
- Fix post, preun scriptlets and add Requires for installing info
  files

Spec URL: http://alexlan.fedorapeople.org/reviews/emacs-common-ess.spec
SRPM URL:
http://alexlan.fedorapeople.org/reviews/emacs-common-ess-5.3.6-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.