[Bug 248677] Review Request: R-BSgenome.Celegans.UCSC.ce2 - BSgenome.Celegans.UCSC.ce2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-BSgenome.Celegans.UCSC.ce2 - BSgenome.Celegans.UCSC.ce2


https://bugzilla.redhat.com/show_bug.cgi?id=248677


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-11-18 20:30 EST -------
This package build fine; rpmlint has only the usual complaints.

I see that you're specifying LGPLv2+, but as usual for these packages I can't
find any statement anywhere that says which version of the license it's really
under.  Did you find some more precise statement of the license somewhere?

One thing to consider: this is a large package and I doubt it will change very
quickly.  To avoid having to carry separate packages for multiple distributions,
is is possible to remove the %dist tag and then just build this package for F-7
(or the oldest distro you wish to support) and it will be inherited into later
distros.  (You would still have to go do bodhi and issue an update for F-8 but
it would automatically make it into rawhide).

Of course, this would only work if the package isn't dependent on the version of
R it was built with.  I have no idea if that's the case.

Obviously I can't install this due to missing dependencies.  I know you're
trying to bootstrap this but at this point I don't even see Biostring or
BSgenome up for review, and I really can't approve this without at least looking
at them.  It would be pointless to let this into the distro at this point
anyway.  For circular dependencies, you really need to submit all of the
packages or a review is kind of pointless.

* source files match upstream:
   2b45b513a80c44791ed91ea7838fa6a5986c2063d3e07634cdd5ec4ab71742ab  
   BSgenome.Celegans.UCSC.ce2_1.2.0.tar.gz
* package meets naming and versioning guidelines.
* Package follows R noarch packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
X package fails to install due to missing dependencies.
* rpmlint has only the expected complaints.
* final provides and requires are sane:
   R-BSgenome.Celegans.UCSC.ce2 = 1.2.0-2.fc9
  =
   /bin/sh
   R
   R-BSgenome
   R-Biostring

X %check disabled due to missing dependencies.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R index generation).
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.