[Bug 244593] Review Request: postgresql-pgbouncer - Lightweight connection pooler for PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-pgbouncer - Lightweight connection pooler for PostgreSQL


https://bugzilla.redhat.com/show_bug.cgi?id=244593





------- Additional Comments From s-t-rhbugzilla at wwwdotorg.org  2007-11-19 00:58 EST -------
A few quick comments:

URLs given for URL and Source0 don't work. The hostname on its own doesn't even
produce anything useful either.

Description seems a little short, but maybe it's OK. If/when the website comes
back, I would check it against what it says there.

I have no idea what the following does. It might be useful to explain what it
does and why it's needed.
%define debug 0
%{?debug:%define __os_install_post /usr/lib/rpm/brp-compress}

Being anal, there should be a blank line after the Summary line.

I'd prefer to reformat this:

%build
%configure \
%if %debug
	--enable-debug \
	--enable-cassert \
%endif
--datadir=%{_datadir} 

... to this:

%build
%configure \
%if %debug
    --enable-debug \
    --enable-cassert \
%endif
    --datadir=%{_datadir}

i.e. line up the options so it's more obvious they're all one command. Also I
hate TABs, but that may be a personal thing.

I've seen some reviews request that file permissions in %files be more explicit.
Instead of relying on %install to set them correctly, you may want to do
something explicit, modelled after the following:

%files
%defattr(0644,root,root,0755)
%doc COPYING
%doc README.txt
%attr(0755, root, root) /sbin/fxload
%{_mandir}/*/*


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.