[Bug 280751] Review Request: qmmp - Qt-based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qmmp - Qt-based multimedia player


https://bugzilla.redhat.com/show_bug.cgi?id=280751





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-11-20 15:14 EST -------
Created an attachment (id=265261)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=265261&action=view)
PATCH fixing the problems with install permissions

(In reply to comment #14)
> > Its not a broken machine %{?_smp_mflags} with badly written makefiles will
> > break builds depending on timing, its a race condition problem, which
> > depends on timing, which will change depeding on workload and speed
> > of the machine.
> 
> it seems to me very strange ... see comment #7
> 
> how does it come that there is problem only on one machine, and it is 
> reproducible, if I get it right?
> 

Well usually it is reproducable, on a certain machine when idle, and not on
another while idle, adding an additional workload can further randomize things,
then again you may be right and maybe something really is wrong with the
machine in subject, but either way better safe then sorry, its not like using
smpflags will save hours of buildtime.

> badly written makefiles? - they are generated by cmake, I've never seen such 

> problem, and I use parallel building heavily ...
> 

Well, even with cmake the people writing the CMakeLists can do stupid things,
see below.

> > I'll see if I can recreate the permission problem and figure out
> > whats going on.
> 
> ok, looking forward to hear from you

UGH, the CMakeLists file in the src dir explictly sets install permissions and
pretty bogus ones, patch fixing this attached.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.