[Bug 390571] Review Request: eclipse-setools - SETools Eclipse Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-setools - SETools Eclipse Plugin


https://bugzilla.redhat.com/show_bug.cgi?id=390571





------- Additional Comments From overholt at redhat.com  2007-11-21 12:47 EST -------
Hi,

There really isn't much to know about packaging Eclipse plugins :).

For building, either they build with PDE Build or they use some custom build
procedure.  This plugin seems to fall into the latter category.  I don't know if
the BuildArch is necessary.

I can't comment on specific build issues since I haven't tried building, but I
am curious about the fragments.  What platform-specific bits are there?  Some
sort of JNI bits?  Fragments should go in arch-specific dirs like
%{_libdir}/eclipse/plugins to meet LSB compliance.  Other than that small issue,
it looks to me like things are good with the package.  The Fedora review process
may of course find other issues, but from a high-level standpoint, it looks fine
to me :)

HTH,

Andrew "man, that looks ramble-y" Overholt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.