[Bug 280751] Review Request: qmmp - Qt-based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qmmp - Qt-based multimedia player


https://bugzilla.redhat.com/show_bug.cgi?id=280751





------- Additional Comments From kvolny at redhat.com  2007-11-21 14:33 EST -------
(In reply to comment #15)
> Created an attachment (id=265261)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=265261&action=view) [edit]
> PATCH fixing the problems with install permissions

thanks, included
new files:
Spec URL: http://sn.bluehost.cz/tmp/no-mp3/qmmp.spec
SRPM URL: http://sn.bluehost.cz/tmp/no-mp3/qmmp-0.1.4-5.fc8.src.rpm

> ... its not like using smpflags will save hours of buildtime.

ok, I just though we should find the error ...

> UGH, the CMakeLists file in the src dir explictly sets install permissions 
and
> pretty bogus ones, patch fixing this attached.

I see ... I must have been blind :-(

(In reply to comment #16)
> Well, that pretty much wraps qmmp (add the patch and its approved), is there
> anything else you are planning / working on packaging, I would like to walk
> through atleast one other review with you before sponsoring you.

nothing right now ... I looked at KSquirrel, since I recently made Czech 
translation for it, but it seems that the 3rd party Fedora package is 
maintained pretty well

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.