[Bug 391091] Review Request: snake - a client/server python framework used to support anaconda installations

Wed Nov 21 21:02:51 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  snake - a client/server python framework used to support anaconda installations

https://bugzilla.redhat.com/show_bug.cgi?id=391091

------- Additional Comments From jlaska at redhat.com  2007-11-21 16:02 EST -------
(In reply to comment #4)

> 1) numerous extraneous trailing spaces that should be deleted (shows up bright
> red w/my vim setup).

Great catch, thanks ... I've added the same .vimrc checks and fixed this

> 2) The awk thingies for Version and Release... Ew. Not particularly happy for
a fedora package, though I dunno if it strictly violates guidelines or not.

This was taken directly from another fedora project.  It was new for me as well.
   Changed things around a bit to use the spec file as the definitive source for
Version and Release.

> 3) spacing from one %section to another is a bit inconsistent (not a mustfix,
> but something that always bugs me).

Good catch, cleaned up and should be consistent now.

> 4) the %description for server should be wrapped at 80 characters (rpmlint
will complain about this)

Fixed

> 5) use of /var instead of %{_localstatedir}
> 6) use of /etc instead of %{_sysconfdir}

Fixed

> 7) changelog versioning doesn't match rpm versionsing (i.e., 0.9-1 is not the
> same as 0.9-0.3git)

Gotcha, okay this should line up now.

> Now for a glance at rpmlint output...

> 1) non-executable-script errors on a bunch of .py files (all 0644)
> 
> 2) the changelog thing mentioned above

should be fixed now ... reran rpmlist and it's happy

> 3) the %description server line length thing

same ... rpmlint seems happy now

> 4) warning about the snake-server initscript enabling it by default. The
> guidelines generally don't permit services to be enabled by default, it should
> be left to the user to enable the service.

Oh good catch, fixed

> 5) the 0660 perms on the files that comprise the srpm should generally be 0644.

Okay, that should be clean now

> Either remedy the above issues or provide justification why you don't need to,
> and we'll rinse and repeat 'til we're both happy. :)

The only rpmlint output that remains is the following.  Any thoughts as to
whether this needs to be addressed?

$ rpmlint snake-0.9-0.4git.fc8.src.rpm snake-0.9-0.4git.fc8.noarch.rpm
snake-server-0.9-0.4git.fc8.noarch.rpm 
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/machineinfo.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/zeroconf.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/tree.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/client.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/dbushelper.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/uri.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/install.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/saverestore.py 0644
snake.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/xmlhelper.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/labquery.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/config.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/treedb.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/plugins.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/labindex.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/log.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/server.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/dbushelper.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/kickstart.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/ksdb.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/machine.py 0644
snake-server.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/snake/compose.py 0644

Updated spec and source available at the following URLs:

Spec URL: http://jlaska.fedorapeople.org/snake/snake.spec
SRPM URL: http://jlaska.fedorapeople.org/snake/snake-0.9-0.4git.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.