[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741





------- Additional Comments From richip at richip.dhs.org  2007-11-23 11:49 EST -------
(In reply to comment #33)
> Some comments:
> * I guess copying them from config.{guess,sub} from %_datadir/libtool 
>   is sufficient for "sh bootstrap" (and this work for me).
>   (BR: libtool is needed)

Personally, I prefer my srpms to have options to compile from autoconf. At least
it gets to check that the packages are still compatible with the newest version
not to mention some packages may need it across different versions of Fedora.
But since it's currently discouraged, I've generated configure myself and used
that as source.

> * Don't use "make install-strip". Stripping binaries by yourself 
>   disables debuginfo rpm creation.

How do I get rid of the rpmlint warning that keeps complaining of unstripped
binaries?

> * Please use %find_lang, desktop-file-install (BR: desktop-file-utils
>   needed)

The latest version of the src.rpm linked above (gnome-hearts ... oops .. I
linked to the wrong src.rpm ... it should be:

http://richip.dhs.org/~richip/gnome-hearts-0.2-3.svn163.fc8.src.rpm
                                               ^
). That one has the fixes. I'll generate a new one to fix the "make
install-strip" as soon as I get a reply as to what to do about the rpmlint
warnings (disregard?)
> 
> (In reply to comment #32)
> > One thing to note, though, is that the original source package had a Make target
> > of install-desktopDATA which uses "install" to copy the .desktop file. Should
> > this be removed from upstream? From the packages? Or be left alone? Would it
> > make sense for upstream to use desktop-file-install? Or should that target just
> > be removed?
> I don't think there is any reason upstream should change the behavior about
> installing desktop file.
> 
> 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.