[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome
bugzilla at redhat.com
bugzilla at redhat.com
Sat Nov 24 10:43:32 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome
https://bugzilla.redhat.com/show_bug.cgi?id=291741
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka at ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-11-24 05:43 EST -------
Well, perhaps almost okay. However perhaps it will be next monday
when I check this review request next time.
Some quick comments:
- License seems GPLv2+
- %python_sitelib macro seems unused so please remove this macro
and unused %{python_sitelib}/gnome-hearts comment.
- scrollkeeper-update must be called
Please refer to
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
- Please add
--------------------------------------------
DESTDIR="install -p"
--------------------------------------------
to "make install" to keep timestamps on installed files.
While there are some cases in which this method doesn't work,
this method usually works for recent Makefiles.
- Including license text as %doc is needed when possible.
Please add "COPYING{-DOCS}" to %doc.
And:
-------------------------------------------------------------
NOTE: Before being sponsored:
This package will be accepted with another few work.
But before I accept this package, someone (I am a candidate)
must sponsor you.
Once you are sponsored, you have the right to review other
submitters' review requests and approve the packages formally.
For this reason, the person who want to be sponsored (like you)
are required to "show that you have an understanding
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
(at the time you are not sponsored, you cannot do
a formal review)
When you have submitted a new review request or have pre-reviewed other
person's review request, please write the bug number on this bug report
so that I can check your comments or review request.
Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")
Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list