[Bug 397211] Review Request: redet - Regular expression development and execution tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: redet - Regular expression development and execution tool


https://bugzilla.redhat.com/show_bug.cgi?id=397211


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From pertusus at free.fr  2007-11-25 17:42 EST -------
%{_datadir} is still not used 
I suggest:
  's|set NonBinPath \[file join /usr local share Redet\];|set NonBinPath \[file
join %{_datadir} Redet\];|' redet.tcl > redet.tcl.tmp

I also suggest using
%{_mandir}/man1/%{name}.1*

In any case, 

* follow guidelines
* upstream source
09812846ab653dacbb0adf2a61927fbf  redet-8.23.tar.gz
* use rpm macros
* %files section right

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.