[Bug 394651] Review Request: asio - cross-platform C++ library for network programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asio - cross-platform C++ library for network programming


https://bugzilla.redhat.com/show_bug.cgi?id=394651





------- Additional Comments From pertusus at free.fr  2007-11-25 19:43 EST -------
It cannot be installed with the
Requires:      %{name} = %{version}-%{release}

A BuildRequires and a Requires openssl-devel is missing, and a 
Requires boost-devel is also missing.

A dot is missing at the first devel %description sentence end.

the following are not useful right now, since there is no lib:
%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

COPYING file should be in %doc

The content of the doc directory should be shipped, either in 
devel or in a doc subpackage if you find it too big. See the
guidelines for further recommendations.

I think it would be much better to have timestamps kept, this 
should be achived with
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'

I suggest using %{version} in
Source0: http://downloads.sourceforge.net/asio/asio-%{version}.tar.bz2
but it is only a suggestion.

I also suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.