[Bug 369381] Review Request: glade3 - User Interface Designer for GTK+ and GNOME

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 26 07:33:17 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glade3 - User Interface Designer for GTK+ and GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=369381





------- Additional Comments From tim.lauridsen at googlemail.com  2007-11-26 02:33 EST -------
MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* /sbin/ldconfig used in packages containing libraries.
* rpath is removed.
* GUI app, has .desktop file and uses desktop-file-install to install it.
* header files goes into -devel sub-package.
* *.so goes into -devel sub-package.
* devel package require the base package using a fully versioned dependency
* *.la files is deleted.
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* The spec file handles locales properly (%find_lang )
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list