[Bug 398791] Review Request: BlockOutII - A free adaptation of the original BlockOut DOS game

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 26 10:38:21 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: BlockOutII - A free adaptation of the original BlockOut DOS game
Alias: BlockOutII

https://bugzilla.redhat.com/show_bug.cgi?id=398791





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-11-26 05:38 EST -------
(In reply to comment #1)
> Does not build. :(
> http://koji.fedoraproject.org/koji/taskinfo?taskID=257881

Hmm, oops I've patched it to use the system version of libpng instead of the
included copy, but I forgot to add a BuildRequires for libpng-devel

(In reply to comment #2)
> Hans, another quick comment with respect to your regeneration comments,
> 
> * cvs -z3 -d:pserver:anonymous at blockout.cvs.sourceforge.net:/cvsroot/blockout co
> -P blockout
> 
> This line should probably include date or a tag to ensure that the same sources
> are checked out at any point in the future.
> 

Fixed

> * mv blockout %{name}-%{version}
> 
> Please remove the %{name}-%{version} from this line
> 

? You mean explicitly type the name and version instead of using macros? That
will most likely get stale when the version changes.

> * <convert BlockOut/sounds/music.mp3 to ogg>
> 
> How do I perform this step??

I use mp32ogg (simple perl script, all deps are in fedora except for mpg321),
but I'm leaving this open to the reader as there is no supported way todo this
under Fedora.

Here is a new fixed version:
Spec URL: http://people.atrpms.net/~hdegoede/BlockOutII.spec
SRPM URL: http://people.atrpms.net/~hdegoede/BlockOutII-2.3-2.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list