[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome
bugzilla at redhat.com
bugzilla at redhat.com
Mon Nov 26 16:28:13 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome
https://bugzilla.redhat.com/show_bug.cgi?id=291741
------- Additional Comments From richip at richip.dhs.org 2007-11-26 11:28 EST -------
(In reply to comment #40)
> Btw, get rid of the %if use_network stuff. Everywhere. Just looking back at
> the history of things, your spec from comment 0 looked pretty much like it's
> supposed to look. Just change the version/revision, and add the
> desktop-file-install stuff, find_lang stuff, add the extra BuildRequires, and
> install -p stuff. Then make sure it passes rpmlint and builds in mock, and it'd
> be pretty much ready to ship. The original spec looked so much cleaner. :-)
Mind if I just clean it up a bit? I'd rather have use_network there while I
track the alpha releases and I'd like to avoid having two spec files for now
(I've already had several cases of editing one file when I meant to edit the other).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list