[Bug 396131] Review Request: munipack - MuniPack is a CCD photometry package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: munipack - MuniPack is a CCD photometry package


https://bugzilla.redhat.com/show_bug.cgi?id=396131


lkundrak at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From lkundrak at redhat.com  2007-11-27 06:37 EST -------
Thanks for the package! All the outstainding issues were addressed, the package
now builds cleanly, with rpmlint silent and has a very nicely written SPEC file :)

Therefore, the package is

APPROVED

The only issue that might be worth fixing is that you install shell script
darkbad and a binary darkbat.bin into bindir, and similarly for flabat. I assume
that the shell scripts are wrappers for the binary files. If it is the case,
libexecdir might be better place for the .bin files. Please consult FHS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.