[Bug 225955] Merge Review: jwhois

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jwhois


https://bugzilla.redhat.com/show_bug.cgi?id=225955





------- Additional Comments From vcrhonek at redhat.com  2007-11-27 08:28 EST -------
(In reply to comment #1)
> You don't use _smp_mflags at all

I found no bug against _smp_flags in history and it works, so I will add it.

> You don't need to [ "$RPM_BUILD_ROOT" != "/" ] before rm -fr $RPM_BUILD_ROOT

I will remove it.

> RPMlint:
> 
> jwhois.src:11: W: unversioned-explicit-obsoletes fwhois
> jwhois.src:11: W: unversioned-explicit-obsoletes whois
> 
> Just fine if jwhois is incompatible. Is it?

I think so, but I'm not sure. AFAIK fwhois and whois are not used in Fedora,
fwhois is dead...? Mirek, do you know more about it?

> jwhois.src:65: W: macro-in-%changelog lang
> 
> use double %.

I will fix it.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.