[Bug 399461] Review Request: dsniff - Tools for network auditing and penetration testing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dsniff - Tools for network auditing and penetration testing


https://bugzilla.redhat.com/show_bug.cgi?id=399461


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From pertusus at free.fr  2007-11-28 04:01 EST -------
I personally don't like very much adding new features as patches,
like the patch pcap_read_dump does, but it is not a blocker.

Shouln't dsniff.magic be %config and not %config(noreplace)?

If you want to keep the man pages timestamps (not a must), you 
can try adding INSTALL='install -p' or similar on the make install line.

I suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root)

Regarding the license, remote.c base64.c looks more MIT to me than BSD, 
and magic.c is under a license I have never seen before. It may be argued
that dsniff isn't fully compliant with this license since the name of some
authors doesn't seems to be in the documentation as asked for. However
no authors really appears in the documentation since there is no AUTHORS
or CREDITS file. Not a blocker, but may be worth reporting upstream,
though looks like upstream is dead, so reporting to debian could be 
relevant.


Please take those comments into account when you feel they are
relevant, but these are not blockers.

* rpmlint is silent
* follow packaging and naming guidelines
* free software license. An author of one file who ask for being in the 
  documentation isn't mentioned in this documentation, but no author
  is mentioned in the documentation
* match upstream
2f761fa3475682a7512b0b43568ee7d6  dsniff-2.4b1.tar.gz
* %files section right

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.