[Bug 390571] Review Request: eclipse-setools - SETools Eclipse Plugin
bugzilla at redhat.com
bugzilla at redhat.com
Wed Nov 28 14:19:56 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: eclipse-setools - SETools Eclipse Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=390571
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-11-28 09:19 EST -------
Sorry for delay.
Well, while actually I don't know about eclipse,
For 3.3.0-4:
! First of all, the formal release 3.3.2 seems to be there.
* %setup
- %setup is not quiet. Please use "%setup -q".
* License
- Now the license tag "GPL" is not valid for Fedora.
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
http://fedoraproject.org/wiki/Licensing
By the way, how we can know that this is licensed under
GPL?
* Perl modules dependency
- For perl modules dependency, please write not the rpm name directly
but the module name the rpm provides, for example:
---------------------------------------------------
BuildRequires: perl(XML::XPath)
---------------------------------------------------
ref:
http://fedoraproject.org/wiki/Packaging/Perl
* Timestamps
- When using "cp" or "install" to install files, please add
"-p" option to keep timestamps on installed files.
* Files entry
- Now we recommend %defattr(-,root,root,-)
- By the way, the %files entry
----------------------------------------------------
%files
%dir foo/
foo/*
----------------------------------------------------
can be simplified by
----------------------------------------------------
%files
foo/
----------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list