[Bug 225704] Merge Review: docbook-style-xsl

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 29 10:50:45 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: docbook-style-xsl


https://bugzilla.redhat.com/show_bug.cgi?id=225704


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-11-29 05:50 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM But NOT for RPM.
docbook-style-xsl.noarch: W: file-not-utf8
/usr/share/doc/docbook-style-xsl-1.73.2/doc/reference.pdf.gz
=> these messages can be ignored for this package.
+ source files match upstream.
7dd72a38c7d25e1396fa26b6ee53eae9  docbook-xsl-1.73.2.tar.gz
d41ce59b783b60383cca765902a41039  docbook-xsl-doc-1.73.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ package docbook-style-xsl-1.73.2-5.fc9 ->
  Provides: docbook-xsl = 1.73.2
  Requires: docbook-dtd-xml xml-common >= 0.6.3-8
+ Not a GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list