[Bug 320421] Review Request: cwrite - console editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwrite - console editor


https://bugzilla.redhat.com/show_bug.cgi?id=320421





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-30 10:25 EST -------
For general packaging guideline, you can refer to
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Well, for 0.1.12-1:
* License tag
  - Now the license tag "GPL" is invalid for Fedora.
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
    http://fedoraproject.org/wiki/Licensing

* SourceURL
  - Please write the correct URL for Source0
    ("Correct" here means that from the written URL we can
     download the tarball used in srpm directly by "wget -N",
     for example).

* Parallel make support
  - Support parallel make if possible (please refer to
    the section "Parallel make" of "Guildlines" wiki page.

* Timestamps
  - When you use "cp" or "install" commands in spec file, 
    please add "-p" option to keep timestamps on installed
    files.

* chmod in %post
  - Why is this needed?

* info scriptlet
  - Please refer to the section "Texinfo" of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

* defattr
  - Now we recommend %defattr(-,root,root,-)

* Directory ownership issue
-------------------------------------------------
%files
%{_datadir}/%{name}/*
-------------------------------------------------
  - This causes:
-------------------------------------------------
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/share/cwrite/help.txt 
cwrite-0.1.12-1.fc9
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/share/cwrite
file /usr/share/cwrite is not owned by any package
-------------------------------------------------
    i.e. the directory %_includedir/%name is not owned by any package.
    You can fix this by
-------------------------------------------------
%files
%{_datadir}/%{name}/
-------------------------------------------------
    This contains the directory %_datadir/%name itself *and*
    all files/directories/etc under %_datadir/%name.

* Changelog
  - The contents of %changelog is strange :)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.