[Bug 302361] Review Request: freecol - The FreeCol multi-player strategy game

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 2 21:56:42 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freecol - The FreeCol multi-player strategy game


https://bugzilla.redhat.com/show_bug.cgi?id=302361





------- Additional Comments From ville.skytta at iki.fi  2007-10-02 17:56 EST -------
Ok, looks pretty good to me, just one non-cosmetic issue remains:

As java-1.7.0-icedtea is required, shouldn't the startup script try to enforce
that (or another Java >= 1.7 implementation)?  Currently it picks the system
default which is set by alternatives and may point to an incompatible JRE.  No
good ideas how to do that though, but maybe hardwiring to /usr/lib/jvm/jre-1.7.0
instead of letting that happen would be an improvement, WDYT?

Then, a couple of cosmetic notes:

freecol.desktop still has the Encoding key (dunno if it was intentionally left).

Comment in the .desktop could be improved, eg. simply
"Comment=Open Source version of Colonization" or "Comment=Colonize America".

The startup script still references wstx, which will result in some error
spewage on the console.  Perhaps remove now and add back when/if the dependency
on wstx is added back?

GPL+ seems correct, although the manual (doc/FreeCol.tex) is GPLv2+.  I suppose
upstream's intention is GPLv2+ for the whole shebang, maybe notify them?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list