[Bug 285331] Review Request: jack-rack - Stereo LADSPA effects rack for the JACK audio API

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 3 21:58:45 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jack-rack - Stereo LADSPA effects rack for the JACK audio API


https://bugzilla.redhat.com/show_bug.cgi?id=285331





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-10-03 17:58 EST -------
okay, I've done a full review:

Must Fix:
---------

* Doesn't build on devel (as already discussed by mail) I fixed thi by adding 
  this line to %setup:
  sed -i 's/-DGTK_DISABLE_DEPRECATED=1//g' src/Makefile.*
* Set vendor to Fedora when installing .desktop file
* jack-rack.x86_64: W: file-not-utf8 /usr/share/doc/jack-rack-1.4.6/NEWS
* License: should be GPLv2+
* .desktop file Categories, drop the Utility, what did CCRMA have here? If they
  had some special X-Foo entries, please preserve these.

Should Fix:
------------
* Drop the "Encoding=.." from the ,desktop, this is deprecated


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list