[Bug 225623] Merge Review: bootparamd
bugzilla at redhat.com
bugzilla at redhat.com
Mon Oct 8 10:15:40 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: bootparamd
https://bugzilla.redhat.com/show_bug.cgi?id=225623
odvorace at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
Flag|needinfo?(odvorace at redhat.co|
|m) |
------- Additional Comments From odvorace at redhat.com 2007-10-08 06:15 EST -------
Hi,
> * Package does not follow Fedora's package naming guildlines
> (wiki: PackageNamingGuidelines)
renamed source tarball so it matches upstream tarball and added correct upstream
source tarball url
> * BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> (wiki: PackagingGuidelines#BuildRoot)
corrected the BuildRoot
> * Encoding should be UTF-8
removed invalid character from spec file
> * The package should contain the text of the license
> (wiki: Packaging/ReviewGuidelines)
the upstream package does not contain the text of the license so I can't add the
license text to the tarball
> * Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets)
> * Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets)
corrected scriptlets according to the ScriptletsSnippets
RPMLINT:
Source RPM:
> W: bootparamd summary-ended-with-dot A server process which provides boot
information to diskless clients.
removed dot
> E: bootparamd tag-not-utf8 %changelog
removed invalid character from changelog
> W: bootparamd no-url-tag
there is no bootparamd page
> W: bootparamd strange-permission bootparamd.init 0775
don't know what to do with that, many other services has the same problem
> E: bootparamd non-utf8-spec-file bootparamd.spec
removed invalid character from spec file
> W: bootparamd prereq-use /sbin/chkconfig /etc/init.d
removed prereq use and added correct requires according to the ScriptletsSnippets
> E: bootparamd use-of-RPM_SOURCE_DIR
removed usage of RPM_SOURCE_DIR
> W: bootparamd mixed-use-of-spaces-and-tabs (spaces: line 49, tab: line 1)
using spaces
rpmlint of bootparamd:
> W: bootparamd summary-ended-with-dot A server process which provides boot
information to diskless clients.
removed dot
> E: bootparamd tag-not-utf8 %changelog
removed invalid character from changelog
> W: bootparamd no-url-tag
there is no bootparamd page
> W: bootparamd conffile-without-noreplace-flag /etc/rc.d/init.d/bootparamd
> E: bootparamd executable-marked-as-config-file /etc/rc.d/init.d/bootparamd
/etc/rc.d/init.d/bootparamd is not a config file
Cheers Ondrej
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list