[Bug 296161] Review Request: ical - An X Window System-based calendar program
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 13 16:04:44 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ical - An X Window System-based calendar program
https://bugzilla.redhat.com/show_bug.cgi?id=296161
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka at ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-10-13 12:04 EST -------
Well, for general packaging issues, please refer to
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
Some random comments for 2.3.3-2:
* Please write the full URL of Source1. Otherwise
write as a comment where you found Source1.
* Please follow the buildroot tag required for Fedora.
* Please check the license. COPYING.GNU is GPL+.
* Use macros correctly. /usr/share must be %_datadir, for
example.
* stripping binaries by yourself is forbidden because
this makes debuginfo rpm useless.
* Please choose whether you choose macros or native commands
For example, while you use %__install, you also use
perk (can be %__perl), make (can be %__make) and so on.
* Please avoid %makeinstall if possible
- For this package, adding 'INSTALL="install" -p' option
to "make install" is preferable because this keeps timestamps
on almost all instaled files.
* When you use "install" or "cp" command, use "-p" option to
keep timestamps.
* Desktop files must be installed by "desktop-file-install"
(BR: desktop-file-utils is needed)
- Category "Application" is deprecated and should be removed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list