[Bug 330921] Review Request: ltsp-config-dhcp - DHCP configuration files for LTSP5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltsp-config-dhcp - DHCP configuration files for LTSP5


https://bugzilla.redhat.com/show_bug.cgi?id=330921


wtogami at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wtogami at redhat.com




------- Additional Comments From wtogami at redhat.com  2007-10-13 17:49 EST -------
http://togami.com/~warren/fedora/ltsp-config-dhcp-0-2.fc8.src.rpm
Some minor cleanups and thinko corrections, listed below.

diff -u ltsp-config-dhcp-0-1.fc8.orig/ltsp-config-dhcp.spec
ltsp-config-dhcp-0-1.fc8/ltsp-config-dhcp.spec
--- ltsp-config-dhcp-0-1.fc8.orig/ltsp-config-dhcp.spec 2007-10-13
14:33:25.000000000 -0400
+++ ltsp-config-dhcp-0-1.fc8/ltsp-config-dhcp.spec      2007-10-13
17:42:04.000000000 -0400
@@ -1,19 +1,22 @@
-Name: ltsp-config-dhcp         
-Version: 0       
-Release:        1%{?dist}
-Summary: Default configuration for LTSP5
-
-Group:  System       
-License: GPL
-Source0: ltsp-dhcpd.conf
-Source1: ltsp-dhcpd.init
-BuildArch: noarch
+Name:           ltsp-config-dhcp         
+Version:        0       
+Release:        2%{?dist}
+Summary:        Default configuration for LTSP5 dhcpd
+
+Group:          System Environment/Daemons     
+License:        GPL+ or ISC
+# LTSP is all GPL
+Source0:        ltsp-dhcpd.conf
+# Copied from dhcp-3.0.6 and slightly modified, ISC licensed
+Source1:        ltsp-dhcpd.init
+BuildArch:      noarch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 Requires:    dhcp >= 3.0 
 
 %description
-Default configurations for LTSP5
+Default configuration for LTSP5 dhcpd
+Highly recommended that you check/edit the network information before running!
 
 %prep
 
@@ -36,6 +39,8 @@
 
 
 %changelog
+* Sat Oct 13 2007 Warren Togami <wtogami at redhat.com> 0-2
+- minor cleanups
+
 * Sat Oct 13 2007 Eric Harrison <eharrison at mesd.k12.or.us>
 - first build
-
diff -u ltsp-config-dhcp-0-1.fc8.orig/ltsp-dhcpd.conf
ltsp-config-dhcp-0-1.fc8/ltsp-dhcpd.conf
--- ltsp-config-dhcp-0-1.fc8.orig/ltsp-dhcpd.conf       2006-03-30
21:55:17.000000000 -0500
+++ ltsp-config-dhcp-0-1.fc8/ltsp-dhcpd.conf    2007-10-13 17:42:08.000000000 -0400
@@ -1,7 +1,4 @@
-# Sample configuration file for ISCD dhcpd
-#
-# Don't forget to set run_dhcpd=1 in /etc/init.d/dhcpd
-# once you adjusted this file and copied it to /etc/dhcpd.conf.
+# Sample configuration file for K12LTSP dhcpd
 #
 
 default-lease-time            21600;
diff -u ltsp-config-dhcp-0-1.fc8.orig/ltsp-dhcpd.init
ltsp-config-dhcp-0-1.fc8/ltsp-dhcpd.init
--- ltsp-config-dhcp-0-1.fc8.orig/ltsp-dhcpd.init       2007-10-12
01:32:07.000000000 -0400
+++ ltsp-config-dhcp-0-1.fc8/ltsp-dhcpd.init    2007-10-13 17:42:08.000000000 -0400
@@ -1,7 +1,7 @@
 #!/bin/sh
 #
 ### BEGIN INIT INFO
-# Provides: dhcpd-ltsp
+# Provides: ltsp-dhcpd
 # Default-Start: 2 3 4 5
 # Default-Stop: 0 1 6
 # Should-Start:
@@ -75,7 +75,7 @@
     RETVAL=$?
     [ $RETVAL -eq 0 ] && return $RETVAL
 
-    echo -n $"Starting $prog: "
+    echo -n $"Starting ltsp-$prog: "
     daemon $dhcpd $DHCPDARGS 2>/dev/null
     RETVAL=$?
     echo


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.