[Bug 339631] Review Request: tcputils - Utilities for TCP programming in shell-scripts

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 19 14:29:48 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcputils - Utilities for TCP programming in shell-scripts


https://bugzilla.redhat.com/show_bug.cgi?id=339631





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-19 10:29 EST -------
For 0.6.2-1

* Timestamps
  - For this package,
------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
------------------------------------------------------
    works to keep timestamps on man files. For this package
    it is really preferable because these man files are written
    more than 10 years ago.

  - Also you may want to keep timestamps on the tarball in
    your srpm. You can use "wget -N", for example.

! %attr
-------------------------------------------------------
%attr(0644, root, root) %{_mandir}/man1/...
-------------------------------------------------------
  - While this is not a problem, I prefer to change the permission
    of files before %install section ends and not to use %attr
    when possible, i.e.
-------------------------------------------------------
%install
.......
chmod 0644 $RPM_BUILD_ROOT%{_mandir}/man1/*
-------------------------------------------------------
    However this is not a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list