[Bug 226278] Merge Review: perl-SGMLSpm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-SGMLSpm


https://bugzilla.redhat.com/show_bug.cgi?id=226278


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-10-22 05:36 EST -------
1)mock build went fine. But I saw rpmlint on RPM reported
perl-SGMLSpm.noarch: W: incoherent-version-in-changelog control 1.03ii-16.2.1
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.
==> remove string " sh: line 0: fg: no job control" from chnagelog

perl-SGMLSpm.noarch: W: invalid-license GPL
==> this looks to me as GPLv2

AND
rpmlint on SRPM reported
perl-SGMLSpm.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.
==>Use "sed -i -e 's|\t|  |g' perl-SGMLSpm.spec"


2) You can add disttag (not mandatory)
3) drop "|| :" from %check
4) mock build worked for me after remove BR: perl 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.