[Bug 240333] Review Request: perl-SQL-Translator - Manipulate structured data definitions (SQL and more)

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 23 20:31:03 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SQL-Translator - Manipulate structured data definitions (SQL and more)
Alias: perl-SQL-Translator

https://bugzilla.redhat.com/show_bug.cgi?id=240333


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-10-23 16:31 EST -------
OK, builds fine for me now; rpmlint is quiet and I don't see anything worth
complaining about.

* source files match upstream:
   48e5e4483e2847a563f02ec1d1f148e72c327bc623c5b59da41cada9590adc09  
   SQL-Translator-0.08001.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (and there's a bunch of them)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane.  See end for list.
* %check is present and all tests pass:
   All tests successful, 2 tests skipped.
   Files=43, Tests=1284, 66 wallclock secs (62.53 cusr +  2.89 csys = 65.42 CPU)
  The two skipped tests are:
   t/18ttschema-producer......skipped
     all skipped: Template v2.15 is is incompatible with SQL::Translator 0.08+
   t/33tt-table-producer......skipped
     all skipped: Template v2.15+ is incompatible with SQL::Translator 0.08+

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Here's the full dependency list:
   perl(Parse::RecDescent::SQL::Translator::Parser::DB2::Grammar)
   perl(SQL::Translator) = 0.08001
   perl(SQL::Translator::Diff)
   perl(SQL::Translator::Filter::DefaultExtra)
   perl(SQL::Translator::Filter::Globals)
   perl(SQL::Translator::Filter::Names)
   perl(SQL::Translator::Parser) = 1.9
   perl(SQL::Translator::Parser::Access) = 1.3
   perl(SQL::Translator::Parser::DB2)
   perl(SQL::Translator::Parser::DB2::Grammar)
   perl(SQL::Translator::Parser::DBI) = 1.10
   perl(SQL::Translator::Parser::DBI::DB2)
   perl(SQL::Translator::Parser::DBI::MySQL) = 1.6
   perl(SQL::Translator::Parser::DBI::Oracle) = 1.2
   perl(SQL::Translator::Parser::DBI::PostgreSQL) = 1.10
   perl(SQL::Translator::Parser::DBI::SQLServer) = 1.6
   perl(SQL::Translator::Parser::DBI::SQLite) = 1.5
   perl(SQL::Translator::Parser::DBI::Sybase) = 1.6
   perl(SQL::Translator::Parser::Excel) = 1.14
   perl(SQL::Translator::Parser::MySQL) = 1.58
   perl(SQL::Translator::Parser::Oracle) = 1.29
   perl(SQL::Translator::Parser::PostgreSQL) = 1.48
   perl(SQL::Translator::Parser::SQLServer) = 1.6
   perl(SQL::Translator::Parser::SQLite) = 1.12
   perl(SQL::Translator::Parser::Storable) = 1.5
   perl(SQL::Translator::Parser::Sybase) = 1.10
   perl(SQL::Translator::Parser::XML) = 1.2
   perl(SQL::Translator::Parser::XML::SQLFairy) = 1.15
   perl(SQL::Translator::Parser::YAML) = 1.8
   perl(SQL::Translator::Parser::xSV) = 1.16
   perl(SQL::Translator::Producer) = 1.8
   perl(SQL::Translator::Producer::DB2) = 1.5
   perl(SQL::Translator::Producer::DiaUml) = 1.2
   perl(SQL::Translator::Producer::Diagram) = 1.13
   perl(SQL::Translator::Producer::Dumper) = 1.9
   perl(SQL::Translator::Producer::GraphViz) = 1.14
   perl(SQL::Translator::Producer::HTML) = 1.15
   perl(SQL::Translator::Producer::Latex) = 1.1
   perl(SQL::Translator::Producer::MySQL) = 1.52
   perl(SQL::Translator::Producer::Oracle) = 1.34
   perl(SQL::Translator::Producer::POD) = 1.5
   perl(SQL::Translator::Producer::PostgreSQL) = 1.29
   perl(SQL::Translator::Producer::SQLServer) = 1.7
   perl(SQL::Translator::Producer::SQLite) = 1.15
   perl(SQL::Translator::Producer::Storable) = 1.5
   perl(SQL::Translator::Producer::Sybase) = 1.9
   perl(SQL::Translator::Producer::TT::Base) = 1.6
   perl(SQL::Translator::Producer::TT::Table) = 1.3
   perl(SQL::Translator::Producer::TTSchema) = 1.11
   perl(SQL::Translator::Producer::XML) = 1.16
   perl(SQL::Translator::Producer::XML::SQLFairy) = 1.20
   perl(SQL::Translator::Producer::YAML) = 1.12
   perl(SQL::Translator::Schema) = 1.26
   perl(SQL::Translator::Schema::Constants) = 1.43
   perl(SQL::Translator::Schema::Constraint) = 1.21
   perl(SQL::Translator::Schema::Field) = 1.26
   perl(SQL::Translator::Schema::Graph)
   perl(SQL::Translator::Schema::Graph::CompoundEdge)
   perl(SQL::Translator::Schema::Graph::Edge)
   perl(SQL::Translator::Schema::Graph::HyperEdge)
   perl(SQL::Translator::Schema::Graph::Node)
   perl(SQL::Translator::Schema::Graph::Port)
   perl(SQL::Translator::Schema::Index) = 1.17
   perl(SQL::Translator::Schema::Object) = 1.8
   perl(SQL::Translator::Schema::Procedure) = 1.8
   perl(SQL::Translator::Schema::Table) = 1.36
   perl(SQL::Translator::Schema::Trigger) = 1.9
   perl(SQL::Translator::Schema::View) = 1.14
   perl(SQL::Translator::Shell)
   perl(SQL::Translator::Utils) = 1.12
   perl(Test::SQL::Translator) = 1.8
   perl-SQL-Translator = 0.08001-1.fc8
  =
   /usr/bin/perl
   perl >= 0:5.004
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Class::Base)
   perl(Class::MakeMethods::Template::Hash)
   perl(Class::MakeMethods::Utility::Ref)
   perl(Config)
   perl(Cwd)
   perl(DBI)
   perl(Data::Dumper)
   perl(Exporter)
   perl(File::Basename)
   perl(File::Find)
   perl(File::Path)
   perl(File::Spec::Functions)
   perl(File::Temp)
   perl(GD)
   perl(Getopt::Long)
   perl(GraphViz)
   perl(IO::Dir)
   perl(IO::Handle)
   perl(IO::Scalar)
   perl(Log::Log4perl)
   perl(Parse::RecDescent)
   perl(Pod::Usage)
   perl(SQL::Translator)
   perl(SQL::Translator::Diff)
   perl(SQL::Translator::Parser::DB2::Grammar)
   perl(SQL::Translator::Parser::DBI::DB2)
   perl(SQL::Translator::Parser::DBI::MySQL)
   perl(SQL::Translator::Parser::DBI::Oracle)
   perl(SQL::Translator::Parser::DBI::PostgreSQL)
   perl(SQL::Translator::Parser::DBI::SQLServer)
   perl(SQL::Translator::Parser::DBI::SQLite)
   perl(SQL::Translator::Parser::DBI::Sybase)
   perl(SQL::Translator::Parser::MySQL)
   perl(SQL::Translator::Parser::SQLite)
   perl(SQL::Translator::Parser::XML::SQLFairy)
   perl(SQL::Translator::Producer::XML::SQLFairy)
   perl(SQL::Translator::Schema)
   perl(SQL::Translator::Schema::Constants)
   perl(SQL::Translator::Schema::Constraint)
   perl(SQL::Translator::Schema::Field)
   perl(SQL::Translator::Schema::Graph)
   perl(SQL::Translator::Schema::Graph::CompoundEdge)
   perl(SQL::Translator::Schema::Graph::Edge)
   perl(SQL::Translator::Schema::Graph::HyperEdge)
   perl(SQL::Translator::Schema::Graph::Node)
   perl(SQL::Translator::Schema::Graph::Port)
   perl(SQL::Translator::Schema::Index)
   perl(SQL::Translator::Schema::Procedure)
   perl(SQL::Translator::Schema::Table)
   perl(SQL::Translator::Schema::Trigger)
   perl(SQL::Translator::Schema::View)
   perl(SQL::Translator::Utils)
   perl(Spreadsheet::ParseExcel)
   perl(Storable)
   perl(Template)
   perl(Text::ParseWords)
   perl(Text::RecordParser)
   perl(XML::XPath)
   perl(XML::XPath::XMLParser)
   perl(YAML)
   perl(base)
   perl(constant)
   perl(strict)
   perl(vars)
   perl(warnings)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list