[Bug 226251] Merge Review: perl-DBD-MySQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-DBD-MySQL
Alias: perl-DBD-MySQL

https://bugzilla.redhat.com/show_bug.cgi?id=226251





------- Additional Comments From panemade at gmail.com  2007-10-24 00:11 EST -------
Review based on current CVS trunk
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM But not for RPM.
  perl-DBD-MySQL.i386: W: file-not-utf8
/usr/share/doc/perl-DBD-MySQL-4.005/ChangeLog
  ==> can be solved as given in comment #2
+ source files match upstream url
39181a061348ad76b67c99326873ccd5  DBD-mysql-4.005.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
+ Package  perl-DBD-MySQL-4.005-3.fc8 ->
  Provides: mysql.so perl(Bundle::DBD::mysql) = 4.004 perl(DBD::mysql) = 4.005
perl(DBD::mysql::GetInfo) perl(DBD::mysql::db) perl(DBD::mysql::dr)
perl(DBD::mysql::st) perl-DBD-mysql = 4.005-3.fc8
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcrypt.so.1
libcrypto.so.6 libm.so.6 libmysqlclient.so.15
libmysqlclient.so.15(libmysqlclient_15) libnsl.so.1 libssl.so.6 libz.so.1
perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DBD::mysql) perl(DBI)
perl(DBI::Const::GetInfoType) perl(DynaLoader) perl(strict) perl(vars)
rtld(GNU_HASH)
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.