[Bug 225903] Merge Review: iproute
bugzilla at redhat.com
bugzilla at redhat.com
Wed Oct 24 09:54:04 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: iproute
https://bugzilla.redhat.com/show_bug.cgi?id=225903
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2007-10-24 05:54 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
20ef2767896a0f156b6fbabd47936f79 iproute2-2.6.22-070710.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
- duplicates in %files present as can be seen in build.log
warning: File listed twice: /sbin/cbq
==> This can be solved at next build time of this package
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package iproute-2.6.22-4.fc8 ->
Provides: config(iproute) = 2.6.22-4.fc8
Requires: /bin/bash config(iproute) = 2.6.22-4.fc8 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.2.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libdb-4.6.so libdl.so.2
libdl.so.2(GLIBC_2.0) libdl.so.2(GLIBC_2.1) libm.so.6 libm.so.6(GLIBC_2.0)
libpthread.so.0 libpthread.so.0(GLIBC_2.0) libresolv.so.2 rtld(GNU_HASH)
+ Not a GUI app.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list