[Bug 226255] Merge Review: perl-Digest-HMAC
bugzilla at redhat.com
bugzilla at redhat.com
Thu Oct 25 04:37:27 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-Digest-HMAC
https://bugzilla.redhat.com/show_bug.cgi?id=226255
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2007-10-25 00:37 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
32dc54c765100c638b5d7f7ff4c5c626 Digest-HMAC-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/rfc2202....ok
All tests successful.
Files=1, Tests=14, 0 wallclock secs ( 0.02 cusr + 0.00 csys = 0.02 CPU)
+ Package perl-Digest-HMAC-1.01-17.fc8 ->
Provides: perl(Digest::HMAC) = 1.01 perl(Digest::HMAC_MD5) perl(Digest::HMAC_SHA1)
Requires: perl(:MODULE_COMPAT_5.8.8) perl(Digest::HMAC) perl(Digest::MD5)
perl(Digest::SHA1) perl(Exporter) perl(strict) perl(vars)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list