[Bug 333451] Review Request: PackageKit - Package management with dbus and policykit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit


https://bugzilla.redhat.com/show_bug.cgi?id=333451


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-26 00:51 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
ad915a2cd3d5028fa6e399e0947aecdc  PackageKit-0.1.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small so no need of -doc subpackage.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ packagekit.pc files are present.
+ -devel,-libs subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ package PackageKit-0.1.0-4.fc8 ->
  Provides: config(PackageKit) = 0.1.0-4.fc8
  Requires: /bin/sh /usr/bin/python PackageKit-libs = 0.1.1-4.fc9
config(PackageKit) = 0.1.1-4.fc9 dbus >= 0.90 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libdbus-glib-1.so.2
libdl.so.2 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0
libgthread-2.0.so.0 libnm_glib.so.0 libpackagekit.so.2 libpolkit-dbus.so.2
libpolkit-grant.so.2 libpolkit.so.2 libpthread.so.0 libpthread.so.0(GLIBC_2.0)
librt.so.1 libsqlite3.so.0 python(abi) = 2.5 rtld(GNU_HASH) yum >= 3.2.6
+ package PackageKit-devel-0.1.0-4.fc8 ->
  Requires: PackageKit = 0.1.1-4.fc9 dbus-devel >= 0.90 libpackagekit.so.2
pkgconfig sqlite-devel
+ package PackageKit-libs-0.1.0-4.fc8 ->
  Provides: libpackagekit.so.2 libpk_backend_dummy.so libpk_backend_test_fail.so
libpk_backend_test_nop.so libpk_backend_test_spawn.so
libpk_backend_test_succeed.so libpk_backend_test_thread.so libpk_backend_yum.so
  Requires: dbus >= 0.90 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libdbus-1.so.3 libdbus-glib-1.so.2 libdl.so.2
libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0
libnm_glib.so.0 libpackagekit.so.2 libpthread.so.0 librt.so.1 rtld(GNU_HASH)
+ Not a GUI app.

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.