[Bug 354441] Review Request: nautilus-share - Easy sharing folder via Samba (CIFS) protocol
bugzilla at redhat.com
bugzilla at redhat.com
Fri Oct 26 18:11:04 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-share - Easy sharing folder via Samba (CIFS) protocol
https://bugzilla.redhat.com/show_bug.cgi?id=354441
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |177841
nThis| |
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-10-26 14:11 EST -------
(In reply to comment #0)
> SRPM URL will not be built by me (I messed up with Rawhide packages)
- What to you mean?
Please upload srpm, otherwise we cannot review your package.
You can create your srpm by "rpm -bs foo.spec".
Anyway some comments (just from a quick look at your spec file)
- Perhaps "Requires: dbus libglade libdaemon" can all be removed.
rpmbuild checks the dependency of this package for libraries and
adds them to Requires automatically.
- Please update License tag (please refer to:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
http://fedoraproject.org/wiki/Licensing )
- Make it sure that all directories created by this package are
owned by this package.
- For example, the directory %{_datadir}/nautilus-share/ is not
owned by any package.
! Note
- When you write
---------------------------------------------------------------------
%files
%{_datadir}/nautilus-share/
---------------------------------------------------------------------
This contains the directory %{_datadir}/nautilus-share/ itself
and all files/directories/etc under %{_datadir}/nautilus-share/.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list