[Bug 226430] Merge Review: squashfs-tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: squashfs-tools


https://bugzilla.redhat.com/show_bug.cgi?id=226430





------- Additional Comments From panemade at gmail.com  2007-08-31 22:09 EST -------
(In reply to comment #2)
> (In reply to comment #1)
> > NEED:-
> >   Use of macros.
> 
> What macros in particular aren't being used that are needed by the guidelines?
  Ah. ok. I thought we also hvae %{_sbindir} macro which replaces /usr/sbin

> 
> >   Change Buildroot to current one.
> 
> Buildroot is one of the three acceptable ones
  ohh. I forgot its not mandatory now from packaging guidelines "At one point,
the second was a mandatory value, but it is now left to the packager to decide."

> 
> >   update license tag
> 
> Updated
  ok
> 
> >   Can use dist tag.
> 
> Given that squashfs-tools depends on kernel version and isn't synchronized
> across branches, the dist tag doesn't buy anything really
  ok.
> 
> > Also, rpmlint on binary rpm reported as
> > W: squashfs-tools summary-not-capitalized squashfs utilities
> > Summary doesn't begin with a capital letter.
> 
> Fixed
> 
> > W: squashfs-tools invalid-license GPL
> 
> Fixed
> 
> > W: squashfs-tools spurious-executable-perm
> 
> And fixed all of these
  Ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.