[Bug 251710] Review Request: potrace - Transforming bitmaps into vector graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: potrace - Transforming bitmaps into vector graphics


https://bugzilla.redhat.com/show_bug.cgi?id=251710


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |jpmahowald at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From jpmahowald at gmail.com  2007-09-02 14:49 EST -------
You now have to specify which version of the license, from README it seems
GPLv2+. See http://fedoraproject.org/wiki/Licensing

The check gives:
Don't have ghostscript, ignoring postscript test.
SKIP: postscript-check.sh
Don't have ghostscript, skipping PDF test.
SKIP: pdf-check.sh

I suggest a BuildRequire, checks are good.

What exactly is the # install libgeotiff  comment in the spec for?
I can't see anything of that description in the tarball.

Instead of Transforming in the Summary, try Transforms. Makes better grammatical
sense I think.

Good:
+ builds on F7 x86_64
+ source matches upstream
+ follows template
+ uses macros
+ %clean section
+ %files section with defattr and using macros
+ smp flags

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.