[Bug 256341] Review Request: micq - Text/line based ICQ client with many features

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: micq - Text/line based ICQ client with many features


https://bugzilla.redhat.com/show_bug.cgi?id=256341





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-04 15:44 EST -------
Some random comments for 0.5.4.2-1:

* %changelog place
  - Please write %changelog at the last of the spec file.
    %changelog will get longer and longer in the future
    and writing %changelog in the middle of the spec file
    makes it difficult to check the spec file easily.

* Unneeded macro
  - Fedora surely has gnutls-devel, tcl-devel and
    _without_ssl macro or so are redundant.

* Parallel make
  - Support parallel make when possible (check the section
    "Parallel make" of
    http://fedoraproject.org/wiki/Packaging/Guidelines )

! From build.log: (available from:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=147235
  http://koji.fedoraproject.org/scratch/mtasaka/task_147235/ )

  * Possibly missing BuildRequires:
------------------------------------------------------
checking for libotr LIBS...  -lotr
checking for libotr headers version 3.x >= 3.0.0... not present.
checking for otrl_message_receiving in -lotr... no
------------------------------------------------------
   - Perhaps libotr-devel is missing from BuildRequires.

  * compilation flags
------------------------------------------------------
make[1]: Entering directory `/builddir/build/BUILD/micq-0.5.4.2/src'
gcc -DHAVE_CONFIG_H -I. -I../include    -DPKGDATADIR='"/usr/share/micq"'
-I../include -O4 -Wall -c -o autopackage_prefix.o autopackage_prefix.c
-------------------------------------------------------
    - Fedora specific compilation flags are not honored
      (please check: "Compiler flags" of
       http://fedoraproject.org/wiki/Packaging/Guidelines )
      ! Note that %configure sets CFLAGS as environment.
        Please check what %configure actually does by
        "rpm --eval %configure".
    - (On Fedora) compilation flag "-O4" is forbidden. This makes debugging
      difficult.

* Lang specific files
--------------------------------------------------------
%files
%{_mandir}/*/man?/*
--------------------------------------------------------
  - Language specific files should be mark properly as %lang(foo),
    e.g.
--------------------------------------------------------
%lang(de) %{_mandir}/de/man?/*
--------------------------------------------------------

* Non-utf8 files
--------------------------------------------------------
micq.i386: W: file-not-utf8 /usr/share/man/uk/man7/micq.7.gz
micq.i386: W: file-not-utf8 /usr/share/man/ru/man7/micq.7.gz
micq.i386: W: file-not-utf8 /usr/share/man/sk/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/sk/man5/micqrc.5.gz
micq.i386: W: file-not-utf8 /usr/share/man/ru/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/sk/man7/micq.7.gz
micq.i386: W: file-not-utf8 /usr/share/man/it/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/uk/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/ru/man5/micqrc.5.gz
micq.i386: W: file-not-utf8 /usr/share/man/pt_BR/man5/micqrc.5.gz
micq.i386: W: file-not-utf8 /usr/share/man/pt_BR/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/pt_BR/man7/micq.7.gz
----------------------------------------------------------
   - These files are not encoded with UTF-8. Please change
     the encoding to UTF-8.

* Questionable permission
-----------------------------------------------------------
micq.i386: W: spurious-executable-perm
/usr/share/doc/micq-0.5.4.2/example-micq-event-script
-----------------------------------------------------------
   - Usually documents should not have executable permission.

* EVR in the changelog
  - Please add EVR (Epoch:Version:Releae) infomation in the %changelog.
    For example:
-----------------------------------------------------------
* Sun Aug 26 2007 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> - 0.5.4.2-1
- rpmlint cleanups
-----------------------------------------------------------
    Note: please increment release number (when version does not
          change) each time you modify your spec/srpm.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.