[Bug 253781] Review Request: outerspace - client for 4x on-line strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: outerspace - client for 4x on-line strategy game


https://bugzilla.redhat.com/show_bug.cgi?id=253781





------- Additional Comments From nsboyle at gmail.com  2007-09-05 00:15 EST -------
It's come to my intention (from other folks, as well as taking a look at it
again after writing it) that the above is difficult to read.  Here's a condensed
version: 

License:
========
COPYING says GPLv2, source files says GPLv2 or later.  AFAIK, what the
source says shows the actual "intent" of the author for licensing.  As such,
license should be GPLv2+.  Please see
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-4d5634799c488896bc50697288213a0b2d9acbae

Source & md5sums:
=================
Version in src.rpm is 30ca7ba6d3b8e632f4ec611a565fb445, upstream is
3ee9e7890392acd53cd5487f33f84f48 (this may be fixed by newer package, but
obviously I can't tell)

Does package build?
===================
In my original post I have the error message.  The reason behind this error is
that you need a "BuildRequires: python-devel".  This can replace the BR: python,
since python-devel will automatically require python.

Macros:
=======
$RPM_BUILD_ROOT could be %{buildroot}

.desktop file:
==============
See
http://fedoraproject.org/wiki/Packaging/Guidelines#head-43fa82f212954e9288ab00a4f250403353c1813d
, basically, you're missing the desktop-file-install command

Release number vs. Version number:
==================================
You incremented the minor version number in your new .spec... whereas you want
to leave that number alone (since it corresponds to upstream source) and instead
increment the Release: number, which corresponds to the package version.  Don't
forget to update the package's %changelog!


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.