[Bug 226109] Merge Review: ltrace

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ltrace


https://bugzilla.redhat.com/show_bug.cgi?id=226109





------- Additional Comments From mlichvar at redhat.com  2007-09-05 09:28 EST -------
The package looks ok, there are just few easy to fix issues.

- rpmlint is silent
- the package is named according to the Package Naming Guidelines
- the spec file name matches the base package %{name}
X the package must meet the Packaging Guidelines
  - please add %{?_smp_mflags} to the make command
  - the line before %configure doesn't seem to be necessary. If it is, please
add a comment. Also would be nice to have a comment for the relro linker flag
  - the package has a test suite, please enable it in %check or add a comment if
there is a reason why it's disabled
- the package is licensed with a Fedora approved license (GPLv2+)
- the License field in the package spec file matches the actual license
- the file containing the text of the license(s) for the package is included in %doc
- the spec file is written in American English
- the spec file for the package is legible
X source URL isn't specified in this package
  - upstream doesn't seem to provide tarball for 0.5, please add a comment to
spec how to generate the tarball. Also, the tarball name probably should contain
the svn string. If it's a prerelease for 0.5, the release tag for the package
should start with 0. We don't want to bump epoch to fix this, so it's better to
keep it as it is.
- all build dependencies are listed in BuildRequires
- the package owns all directories that it creates
- the package does not contain any duplicate files in the %files listing
- permissions on files are set properly
- the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
X the package must consistently use macros
  - in %files section should be %{_bindir}/ltrace, without %{_prefix}
  - %{_sysconfdir}/ltrace.conf instead of /etc/
- the package contains code, or permissible content
- files included as %doc don't affect the runtime of the application
- the package does not own files or directories already owned by other packages
- at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT
- all filenames in rpm packages are valid UTF-8
- the package builds in mock
- the package compiles and builds into binary rpms on all supported architectures
- the package functions as described


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.