[Bug 275831] Review Request: libzzub - Powerful music sequencing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzzub - Powerful music sequencing library


https://bugzilla.redhat.com/show_bug.cgi?id=275831





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-05 09:50 EST -------
Some random comments for 0.2.3-2 (from very quick check:)

(For people who also want to check this spec/srpm, I put
 them given from Alexander by mail on:
 http://mtasaka.fedorapeople.org/Review_request/libzzub/ )

# For spec file:
A. Description stage:
* SourceURL
  - For sourceforge source, please refer to the section
    "Sourceforge.net" of
    http://fedoraproject.org/wiki/Packaging/SourceURL

* Redundant Requires:
-------------------------------------------------
Requires:	zlib
Requires:	jack-audio-connection-kit
Requires:	alsa-lib
-------------------------------------------------
  - All these Requires are redundant (and should be removed)
    because rpmbuild checks the dependencies for libraries
    automatically and the dependencies should pull these
    Requires.

? python dependency
-------------------------------------------------
BuildRequires:	python >= 2.5
Requires:	python >= 2.5
-------------------------------------------------
   - Would you explain why should this package have these
     dependencies (especially Requires)?

B. %prep/%build/%install stage
* Macros
  - Please use macros. For example, /usr -> %_prefix

* Debuginfo rpm issue:
--------------------------------------------------
find $RPM_BUILD_ROOT \
     -type f \
     -perm /a+x \
     -exec strip '{}' \;
--------------------------------------------------
  - Stripping binaries is strictly forbidden.
    * This disables to create debuginfo rpm.
    * Note that creating debuginfo automatically strips
      binaries.

C. %files section
* Directory ownership issue
---------------------------------------------------
%{_libdir}/lunar/fx/*/*.so
---------------------------------------------------
   - Please ensure that all directories this package will
     create are owned by this package.
     Currently %_libdir/lunar and all directories under
     %_libdir/lunar are not owned by any package.

D. rpmlint
----------------------------------------------------
W: file-not-utf8 /usr/share/doc/libzzub-0.2.3/CREDITS.txt
----------------------------------------------------
   * Change the encoding to UTF-8.

----------------------------------------------------
libzzub.src: W: mixed-use-of-spaces-and-tabs (spaces: line 53, tab: line 1)
----------------------------------------------------
   * The specfile mixes use of spaces and tabs for indentation,
     which is a cosmetic annoyance.  Use either spaces or tabs 
     for indentation, not both.

E. arch
   * This package does not be rebuilt on ppc64.
     http://koji.fedoraproject.org/koji/taskinfo?taskID=148578

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.